#1 2015-03-18 20:58:45

f1smf
Member
Registered: 2015-03-18
Posts: 2

bug new firmware MicroAPRS in KISS

Hello, with the new version MicroAPRS in mode KISS the FCS is sent to the trame kiss

exemple :

ax25_format_to_tnc() len=71 82 a0 9e a8 86 62 e0 8c|62 a6 9a 8c 40 f2 ae 92|88 8a 62 40 62 ae 92 88|8a 64 40 65 03 f0 21 2f|37 52 62 77 50 23 68 42|
3e 52 21 47 2f 41 3d 30|30 31 36 34 33 20 31 32|2e 35 56 20 31 36 43 20|
4f 54 31 2b 20 1d 41  = APOTC1pF|1SMF yWI|DE1 1WID|E2 e..!/|7RbwP#hB|>R!G/A=0|01643 12|.5V 16C |OT1+ .A
                      ====                                                                                                                                       ==
I find by or the check of the FCS is made

73, Patrick

Offline

#2 2015-03-20 19:40:10

f1smf
Member
Registered: 2015-03-18
Posts: 2

Re: bug new firmware MicroAPRS in KISS

Hello,

I have to find the error

Before the modification:

2015-03-19 09:53:23 CET: F1SMF-9>APOTC1,WIDE1-1,WIDE2-2,qAR,F1ZCD-10:!/7ReQP#i=>TEG/A=001503 15.0V 14C<0xdb><0x1f>
                                                                                                                                                                                 ____________
After the modification:

2015-03-19 10:53:23 CET: F1SMF-9>APOTC1,WIDE1-1,WIDE2-2,qAR,F1ZCD-10:!/7ReQP#i=>TEG/A=001503 15.0V 14C

Modification in KISS.c

void kiss_messageCallback(AX25Ctx *ctx) {
    fputc(FEND, &serial->uart0);
    fputc(0x00, &serial->uart0);
    for (unsigned i = 0; i < ctx->frame_len-2 ; i++) {
                                                           --                         
73,F1SMF

Offline

#3 2015-04-22 10:27:49

markqvist
Administrator
Registered: 2014-12-01
Posts: 112

Re: bug new firmware MicroAPRS in KISS

Oh my! Can't believe I didn't catch this! Thanks a lot for your report and fix! Beautiful! I have updated the source on GitHub, and also the precompiled images!

Offline

Board footer

Powered by FluxBB